unsecure admin-area
-
Brian Jesse Hendrickson
- State changed from new to open
yes can see the admin area but not make changes
omb has a very good (though still new and buggy) centralized security model
but yes, agreed, should not be able to see it at all
-
Johannes Schirge
Hmm...I just edited your first categorie on openmicroblogger.com/admin
-
Brian Jesse Hendrickson
:-) ok I check it out right now
-
Brian Jesse Hendrickson
insert these 4 lines at line 1508 of /db/library/dbscript/_functions.php
if ( !( in_array( $request->action, $datamodel->allowed_methods, true )))
$action = 'get';if (!($action == 'get'))
return false; -
Brian Jesse Hendrickson
the public_resource() test is supposed to return true only for GET on a resource
-
Brian Jesse Hendrickson
if you want to push the fix I will pull it from your git
-
Brian Jesse Hendrickson
should have an $action = $request->action; before that too
$action = $request->action;
if ( !( in_array( $action, $datamodel->allowed_methods, true )))
$action = 'get';if (!($action == 'get'))
return false; -
Johannes Schirge
Wow, that was really fast! :)
Thank you, it works! -
Brian Jesse Hendrickson
glad you like it! :-)
I can push it if you don't want to
-
Johannes Schirge
Oh, you can't visit the mainpage anymore without being logged in.
If you fix that, you can push it :P
-
Brian Jesse Hendrickson
fixed like this
I will push
$action = $request->action;
if ( !( in_array( $action, $datamodel->allowed_methods, true )))
$action = 'get';if (!($action == 'get' || $action == 'get'))
return false; -
Brian Jesse Hendrickson
oops hold on
-
Brian Jesse Hendrickson
are you sure? did you use the 5-line version? I can see home page not logged in
-
Brian Jesse Hendrickson
$action = $request->action;
if ( !( in_array( $action, $datamodel->allowed_methods, true )))
$action = 'get';
if (!($action == 'get'))
return false;
-
Johannes Schirge
Okay, didn't get the 5 line version. now it works with your last post. Thanks! :)
-
Brian Jesse Hendrickson
hi Johannes,
I just committed all of your fixes, and the security fix too
http://github.com/voitto/openmicroblogger/commits/master
also posted a new dbscript.net/omb.zip
thanks again for your help -brian
-
Brian Jesse Hendrickson
- State changed from open to resolved
-
Scot
Playing around in Identi.ca I noticed an old test account that is still listed by another Identi.ca user under "subscribers.
While the link showed an old Sportstwit profile url (http://www.sportstwit.com/admin), it actually brought me to: http://openmicroblogger.com/admin.
This can't be good,
-
Brian Jesse Hendrickson
- State changed from resolved to open
-
Brian Jesse Hendrickson
Hi Scot,
Could you do me a favor and look at the contents of the .htaccess file at SportsTwit.com
My guess is that the 3rd line says "openmicroblogger.com"
Thanks a lot
-- Brian
-
Johannes Schirge
- Tag changed from admin-area, security-issue to medium-priority
Is this still a problem?
-
Johannes Schirge
- State changed from open to resolved
Okay, no one instead of the admin is able to access the admin menu anymore. Good thing :-)
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.